test(snowflake): add missing ORDER in column default #2044
Conversation
Lee-W
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200 and
pankajastro
as code owners
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
- Coverage 90.40% 90.35% -0.05%
==========================================
Files 75 75
Lines 4324 4323 -1
Branches 537 537
==========================================
- Hits 3909 3906 -3
- Misses 321 330 +9
+ Partials 94 87 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@Lee-W, thanks for working on this!
Do you have any idea why "Build and test astro Python SDK / Build-Docs" is breaking? The change is not related to this change, so I'm approving it. It would be great for us to address that in a separate PR
Not quite sure 🤔 Let me rerun it and see how it works |
|
seems to fail. might need to handle that in another pr |
|
@Lee-W it seems there is a conflict ATM - when you have a chance, please, take a look, so we can merge this |
I just rebased from main and found out it's no longer needed |
Description
What is the current behavior?
python-sdk/tests_integration/databases/test_snowflake.py::test_snowflake_create_table_with_columnsfailsDuring testing on #2043, I found out there's this snowflake failure in integration test
What is the new behavior?
python-sdk/tests_integration/databases/test_snowflake.py::test_snowflake_create_table_with_columnspassesDoes this introduce a breaking change?
no
Checklist